Unused parameter in function RVV-B0012
Bug risk
Minor
6 months ago
—
2 years old
parameter 'reg' seems to be unused, consider removing or renaming it as _
248}
249
250// InitPrometheus is a stub for the receiver prom metrics. Required to satisfy Receiver interface.
251func (rcv *PubSub) InitPrometheus(reg prometheus.Registerer) {252}
parameter 'reg' seems to be unused, consider removing or renaming it as _
163}
164
165// InitPrometheus is a stub for the receiver prom metrics. Required to satisfy Receiver interface.
166func (rcv *HTTP) InitPrometheus(reg prometheus.Registerer) {167}
parameter 't' seems to be unused, consider removing or renaming it as _
1096 t.Errorf("trie.allMetrics:\nwant: %s\ngot: %s\n", files, metrics)
1097 }
1098}
1099func TestTrieCreateThrottleOff(t *testing.T) {1100
1101}
1102func TestTrieCreateThrottle(t *testing.T) {parameter 'ps' seems to be unused, consider removing or renaming it as _
2061
2062 return ""
2063}
2064func (ti *trieIndex) maxCreatesThrottle(ps *points.Points) bool {2065 select {
2066 case keep, open := <-ti.maxCreatesTicker.C:
2067 if keep || !open {parameter 'expand' seems to be unused, consider removing or renaming it as _
150// TODO:
151//
152// add range value validation
153func newGlobState(expr string, expand func(globs []string) ([]string, error)) (*gmatcher, error) { 154 var m = gmatcher{root: &gstate{}, exact: true, expr: expr}
155 var cur = m.root
156 var alters [][2]*gstate
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}