SCC-S1012 · Found `time.Now().Sub(t)` instead of `time.Since(t)`

go-graphite / go-carbon

Active

Found time.Now().Sub(t) instead of time.Since(t) SCC-S1012

Anti-pattern

Major

6 months ago — 4 years old

should use time.Since instead of time.Now().Sub

123
124				start := time.Now()
125				p.Stop()
126				worktime := time.Now().Sub(start) //nolint:gosimple127
128				assert.True(worktime.Seconds() < 1, "maxUpdatesPerSecond: %d, workers: %d", maxUpdatesPerSecond, workers)
129			})

Description

The time.Since(t) helper has the same effect as using time.Now().Sub(t).

time.Since(t) returns the time elapsed since t. It is shorthand for time.Now().Sub(t).

Bad practice

time.Now().Sub(x)

go-graphite / go-carbon

Bad practice

Recommended