Value assigned to a variable is never read before being overwritten SCC-SA4006
Bug risk
Major
2 years ago
—
5 years old
this value of err is never used
121 if testData.retention == "" {
122 testData.retention = "1m:10m,2m:30m"
123 }
124 retentions, err := whisper.ParseRetentionDefs(testData.retention) //nolint125
126 if testData.createWhisper {
127 wsp, err = whisper.Create(filepath.Join(testData.path, testData.name+".wsp"), retentions, whisper.Last, 0.0)this value of iNdEx is never used
2402 if err := mapvalue.Unmarshal(dAtA[iNdEx:postmsgIndex]); err != nil {
2403 return err
2404 }
2405 iNdEx = postmsgIndex2406 m.Metrics[mapkey] = mapvalue
2407 } else {
2408 var mapvalue *MetricDetails
Description
Value has been assigned to a variable, but it is being overwritten before being read. In most cases, this could be a forgotten error check or dead code.
Bad practice
err := Op1()
// error value assigned to "err" by "Op1" is replaced with
// error value assigned by "Op2" before even being read even
// once
err = Op2()
if err != nil {
return err
}
Recommended
// Ignore the error value returned by "Op1"
Op1()
err := Op2()
if err != nil {
return err
}
err := Op1()
// Read the error value assigned to "err" by "Op1"
if err != nil {
return err
}
err = Op2()
if err != nil {
return err
}