Avoid square-bracket notation when accessing properties JS-0049
Anti-pattern
7 months ago
—
10 months old
["class"] is better written in dot notation
18
19function simpleLightbox(properties = {}, customCSS = {}, $elements = []) {
20 if(properties["class"] === undefined)
21 properties["class"] = "lightbox"; 22 let defaultCSS = {
23 "display": "inline-block",
24 "top": "50%",["class"] is better written in dot notation
17}
18
19function simpleLightbox(properties = {}, customCSS = {}, $elements = []) {
20 if(properties["class"] === undefined) 21 properties["class"] = "lightbox";
22 let defaultCSS = {
23 "display": "inline-block",
Description
In JavaScript, there are two ways to access the properties of an object:
- dot-notation
(object.property)( Recommended ) - square-bracket notation
(object["property"])( Bad Practice )
The dot notation is preferred because it is easier to read, less verbose, and works better with aggressive JavaScript minimizers.
Bad Practice
const x = object["property"];
Recommended
const x = object.property;
x = object[y];