Unused parameter in function RVV-B0012
Bug risk
Minor
17 days ago
—
2 years old
parameter 'dbPrefix' seems to be unused, consider removing or renaming it as _
21 return err
22}
23
24func SetTestingDB(dbDriver string, dbName string, dbPrefix string, db *sql.DB) (err error) {25 testutil.PanicIfNotTest()
26 systemCriticalCfg := config.GetSystemCriticalConfig()
27 if systemCriticalCfg.DBname == "" {parameter 'dbName' seems to be unused, consider removing or renaming it as _
21 return err
22}
23
24func SetTestingDB(dbDriver string, dbName string, dbPrefix string, db *sql.DB) (err error) {25 testutil.PanicIfNotTest()
26 systemCriticalCfg := config.GetSystemCriticalConfig()
27 if systemCriticalCfg.DBname == "" {
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}