Unused parameter in function RVV-B0012
Bug risk
3 months ago
—
a year old
parameter 'staffID' seems to be unused, consider removing or renaming it as _
482 return fb.BoardID == nil
483}
484
485func (fb FileBan) Deactivate(staffID int) error {486 const deleteQuery = `DELETE FROM DBPREFIXfile_ban WHERE id = ?`
487 _, err := ExecSQL(deleteQuery, fb.ID)
488 return errparameter 'staffID' seems to be unused, consider removing or renaming it as _
367 return ub.BoardID == nil
368}
369
370func (fnb *FilenameBan) Deactivate(staffID int) error {371 const deleteQuery = `DELETE FROM DBPREFIXfilename_ban WHERE id = ?`
372 _, err := ExecSQL(deleteQuery, fnb.ID)
373 return errparameter 'staffID' seems to be unused, consider removing or renaming it as _
131 return ipb.BoardID == nil
132}
133
134func (ipb *IPBan) Deactivate(staffID int) error {135 const deactivateQuery = `UPDATE DBPREFIXip_ban SET is_active = FALSE WHERE id = ?`
136 const auditInsertQuery = `INSERT INTO DBPREFIXip_ban_audit
137 (ip_ban_id, staff_id, is_active, is_thread_ban, expires_at, appeal_at, permanent, staff_note, message, can_appeal)parameter 'staffID' seems to be unused, consider removing or renaming it as _
373 return err
374}
375
376func (fnb *UsernameBan) Deactivate(staffID int) error {377 const deleteQuery = `DELETE FROM DBPREFIXusername_ban WHERE id = ?`
378 _, err := ExecSQL(deleteQuery, fnb.ID)
379 return errparameter 'errEv' seems to be unused, consider removing or renaming it as _
189 return available
190}
191
192func getStaffActions(writer http.ResponseWriter, request *http.Request, staff *gcsql.Staff, wantsJSON bool, infoEv *zerolog.Event, errEv *zerolog.Event) (interface{}, error) {193 availableActions := getAvailableActions(staff.Rank, false)
194 return availableActions, nil
195}
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}