Assigning result of a function call, where the function has no return PYL-E1111
Bug risk
Critical
2 years ago
—
2 years old
Assigning result of a function call, where the function has no return
122
123 # first we try to get the source for this template together
124 # with the filename and the uptodate function.
125 source, filename, uptodate = self.get_source(environment, name)126
127 # try to load the code from the bytecode cache if there is a
128 # bytecode cache configured.
Description
An assignment is done on a function call but the inferred function doesn't return anything. While this is not an error in Python, it is a critical anti-pattern and can lead to unexpected bugs.
Bad practice
def square(number):
'''Returns the square of a number'''
number ** 2 # Forgot a `return` here
result = square(4)
Recommended
def square(number):
'''Returns the square of a number'''
return number ** 2
result = square(4)