PYL-W0201 · Attribute defined outside `__init_

gootsaud / bike-riding

Active

Attribute defined outside __init__ PYL-W0201

Anti-pattern

Minor

2 years ago — 2 years old

Attribute '_next' defined outside __init__

1647            raise ValueError("buffer size too small")
1648
1649        self.buffered = True
1650        self._next = partial(next, self._buffered_generator(size))1651
1652    def __iter__(self) -> "TemplateStream":
1653        return self

Attribute 'buffered' defined outside __init__

jinja2/environment.py

1646        if size <= 1:
1647            raise ValueError("buffer size too small")
1648
1649        self.buffered = True1650        self._next = partial(next, self._buffered_generator(size))
1651
1652    def __iter__(self) -> "TemplateStream":

Attribute 'code' defined outside __init__

jinja2/bccache.py

 74            return
 75        # if marshal_load fails then we need to reload
 76        try:
 77            self.code = marshal.load(f) 78        except (EOFError, ValueError, TypeError):
 79            self.reset()
 80            return

Description

Defining an instance attribute outside __init__ affects the readability of code. It is expected to find all the attributes an instance may have by reading its __init__ method. If there is a need to initialize attribute via sub-initialization methods, it is recommended to assign attributes to None in the init then call the sub-initialization methods.