Any method in a child class which is only calling the overridden method of any of its base class using super and doing nothing else is unnecessary. If the method isn't present in the child class, Python implicitly looks for the method in its base classes.

This issue is valid only if the method in the child class and the method in the base class has the same signature.

Bad practice

class Egg:
    def __init__(self, first, second):
        pass


class Spam(Egg):
    def __init__(self, first, second):
        super().__init__(first, second)

    def __repr__(self):
        return f'Spam({first}, {second})'

class UselessSuper:

    def useless(self, first, *, second=None, **kwargs):
        super().useless(first, second=second, **kwargs)

Recommended:

class Egg:
    def __init__(self, first, second):
        pass


class Spam(Egg):
    # `__init__` method removed entirely

    def __repr__(self):
        return f'Spam({first}, {second})'


class UselessSuper:
    ...

gootsaud / bike-riding

No ignore rules found