DeepSource
Dashboard Resources Pricing Discover Directory Log in

Run your first analysis.

Find thousands of code security and quality issues in your codebase, before they end up in production.

Start now

grafov / m3u8

Unnecessary dereference expressions GO-R4004
Anti-pattern
Major
6 months ago — 6 months old
could simplify (*item.SCTE).Time to item.SCTE.Time
reader_test.go
 897				} else if (*item.SCTE).ID != c.expectedSCTEID {
 898					t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID)
 899				} else if (*item.SCTE).Time != c.expectedSCTETime {
 900					t.Error("Expected ", c.expectedSCTETime, " got ", (*item.SCTE).Time) 901				}
 902			}
 903		}
could simplify (*item.SCTE).Time to item.SCTE.Time
reader_test.go
 896					t.Error("Expected ", c.expectedSCTECue, " got ", (*item.SCTE).Cue)
 897				} else if (*item.SCTE).ID != c.expectedSCTEID {
 898					t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID)
 899				} else if (*item.SCTE).Time != c.expectedSCTETime { 900					t.Error("Expected ", c.expectedSCTETime, " got ", (*item.SCTE).Time)
 901				}
 902			}
could simplify (*item.SCTE).ID to item.SCTE.ID
reader_test.go
 895				if (*item.SCTE).Cue != c.expectedSCTECue {
 896					t.Error("Expected ", c.expectedSCTECue, " got ", (*item.SCTE).Cue)
 897				} else if (*item.SCTE).ID != c.expectedSCTEID {
 898					t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID) 899				} else if (*item.SCTE).Time != c.expectedSCTETime {
 900					t.Error("Expected ", c.expectedSCTETime, " got ", (*item.SCTE).Time)
 901				}
could simplify (*item.SCTE).ID to item.SCTE.ID
reader_test.go
 894			} else if index == c.expectedSCTEIndex && item.SCTE != nil {
 895				if (*item.SCTE).Cue != c.expectedSCTECue {
 896					t.Error("Expected ", c.expectedSCTECue, " got ", (*item.SCTE).Cue)
 897				} else if (*item.SCTE).ID != c.expectedSCTEID { 898					t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID)
 899				} else if (*item.SCTE).Time != c.expectedSCTETime {
 900					t.Error("Expected ", c.expectedSCTETime, " got ", (*item.SCTE).Time)
could simplify (*item.SCTE).Cue to item.SCTE.Cue
reader_test.go
 893				t.Error("Expecting SCTE information on this segment")
 894			} else if index == c.expectedSCTEIndex && item.SCTE != nil {
 895				if (*item.SCTE).Cue != c.expectedSCTECue {
 896					t.Error("Expected ", c.expectedSCTECue, " got ", (*item.SCTE).Cue) 897				} else if (*item.SCTE).ID != c.expectedSCTEID {
 898					t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID)
 899				} else if (*item.SCTE).Time != c.expectedSCTETime {