Call to
(*testing.T).Fatal and friends from the non-test goroutine GO-W6004
Bug risk
Major
6 months ago
—
a year old
call to (*T).Fatal from a non-test goroutine
608
609 actual := p.Encode().Bytes() // disregard output
610 if bytes.Compare(expect, actual) != 0 {
611 t.Fatal("not matched") 612 }
613 }()
614 wg.Wait()call to (*T).Fatal from a non-test goroutine
603 t.Fatalf("Create media playlist failed: %s", err)
604 }
605 if err = p.DecodeFrom(bufio.NewReader(f), true); err != nil {
606 t.Fatal(err) 607 }
608
609 actual := p.Encode().Bytes() // disregard outputcall to (*T).Fatalf from a non-test goroutine
600 }
601 p, err := NewMediaPlaylist(50000, 50000)
602 if err != nil {
603 t.Fatalf("Create media playlist failed: %s", err) 604 }
605 if err = p.DecodeFrom(bufio.NewReader(f), true); err != nil {
606 t.Fatal(err)call to (*T).Fatal from a non-test goroutine
596 defer wg.Done()
597 f, err := os.Open("sample-playlists/media-playlist-large.m3u8")
598 if err != nil {
599 t.Fatal(err) 600 }
601 p, err := NewMediaPlaylist(50000, 50000)
602 if err != nil {
Description
It is not recommended to call (*testing.T).Fatal and friends from a non-test
goroutine. Functions that abruptly terminate a test, such as the Fatal,
Fatalf, FailNow, Skip, Skipf and SkipNow methods of *testing.T, must
be called from the test goroutine itself.
Bad practice
func TestFoo(t *testing.T) {
go func() {
t.FailNow() // `(*testing.T).FailNow` should be called from a test goroutine
}()
}