could simplify (*item.SCTE).Time to item.SCTE.Time
897 } else if (*item.SCTE).ID != c.expectedSCTEID {
898 t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID)
899 } else if (*item.SCTE).Time != c.expectedSCTETime {
900 t.Error("Expected ", c.expectedSCTETime, " got ", (*item.SCTE).Time) 901 }
902 }
903 }
could simplify (*item.SCTE).Time to item.SCTE.Time
896 t.Error("Expected ", c.expectedSCTECue, " got ", (*item.SCTE).Cue)
897 } else if (*item.SCTE).ID != c.expectedSCTEID {
898 t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID)
899 } else if (*item.SCTE).Time != c.expectedSCTETime { 900 t.Error("Expected ", c.expectedSCTETime, " got ", (*item.SCTE).Time)
901 }
902 }
could simplify (*item.SCTE).ID to item.SCTE.ID
895 if (*item.SCTE).Cue != c.expectedSCTECue {
896 t.Error("Expected ", c.expectedSCTECue, " got ", (*item.SCTE).Cue)
897 } else if (*item.SCTE).ID != c.expectedSCTEID {
898 t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID) 899 } else if (*item.SCTE).Time != c.expectedSCTETime {
900 t.Error("Expected ", c.expectedSCTETime, " got ", (*item.SCTE).Time)
901 }
could simplify (*item.SCTE).ID to item.SCTE.ID
894 } else if index == c.expectedSCTEIndex && item.SCTE != nil {
895 if (*item.SCTE).Cue != c.expectedSCTECue {
896 t.Error("Expected ", c.expectedSCTECue, " got ", (*item.SCTE).Cue)
897 } else if (*item.SCTE).ID != c.expectedSCTEID { 898 t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID)
899 } else if (*item.SCTE).Time != c.expectedSCTETime {
900 t.Error("Expected ", c.expectedSCTETime, " got ", (*item.SCTE).Time)
could simplify (*item.SCTE).Cue to item.SCTE.Cue
893 t.Error("Expecting SCTE information on this segment")
894 } else if index == c.expectedSCTEIndex && item.SCTE != nil {
895 if (*item.SCTE).Cue != c.expectedSCTECue {
896 t.Error("Expected ", c.expectedSCTECue, " got ", (*item.SCTE).Cue) 897 } else if (*item.SCTE).ID != c.expectedSCTEID {
898 t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID)
899 } else if (*item.SCTE).Time != c.expectedSCTETime {
could simplify (*item.SCTE).Cue to item.SCTE.Cue
892 } else if index == c.expectedSCTEIndex && item.SCTE == nil {
893 t.Error("Expecting SCTE information on this segment")
894 } else if index == c.expectedSCTEIndex && item.SCTE != nil {
895 if (*item.SCTE).Cue != c.expectedSCTECue { 896 t.Error("Expected ", c.expectedSCTECue, " got ", (*item.SCTE).Cue)
897 } else if (*item.SCTE).ID != c.expectedSCTEID {
898 t.Error("Expected ", c.expectedSCTEID, " got ", (*item.SCTE).ID)
Description
Avoid unnecessary dereference expressions that can be avoided by using shorthand notations (syntactic sugar) that are available in Go.
Bad practice
_ = (*str).field // replace with str.field
_ = (**str).field // replace with (*str).field
(*k)[2] = 3 // replace with k[2] = 3
Recommended
_ = str.field
_ = (*str).field
k[2] = 3