Appending to dictionary immediately following its definition PY-W0072
Anti-pattern
Major
10 months ago
—
10 months old
Appending to list immediately following its definition
310 self.response = pickle.loads(raw_response)
311
312 def send_request(self, request_type, **kwargs):
313 request = {}314 request['type'] = request_type
315 request.update(kwargs)
316 self.handler.stringReceived(pickle.dumps(request))
Description
Instead of adding items to a dictionary just after creation, it should be refactored to add those items into the dict definition itself.
Bad practice
env = {}
env['HOST'] = 'example.com'
env['PORT'] = 8080
Recommended
env = {'HOST': 'example.com', 'PORT': 8080}