Abstract method not overridden PYL-W0223
Bug risk
Major
4 years ago
—
4 years old
Method 'stringReceived' is abstract in class 'IntNStringReceiver' but is not overridden
463
464
465# Basic clients and associated factories.
466class CarbonPickleClientProtocol(CarbonClientProtocol, Int32StringReceiver):467
468 def _sendDatapointsNow(self, datapoints):
469 self.sendString(pickle.dumps(datapoints, protocol=2))Method 'lineReceived' is abstract in class 'LineOnlyReceiver' but is not overridden
476 return CarbonPickleClientProtocol()
477
478
479class CarbonLineClientProtocol(CarbonClientProtocol, LineOnlyReceiver):480
481 def _sendDatapointsNow(self, datapoints):
482 for metric, datapoint in datapoints:Method 'process' is abstract in class 'Processor' but is not overridden
6
7class ProcessorTest(TestCase):
8 def test_processor_registers(self):
9 class DummyProcessor(Processor):10 plugin_name = "dummy_processor"
11
12 self.assertTrue("dummy_processor" in Processor.plugins)Method 'hasDestination' is abstract in class 'DatapointRouter' but is not overridden
28 return pickle_loads(data[INT32_SIZE:INT32_SIZE + pickle_size])
29
30
31class BroadcastRouter(DatapointRouter): 32 def __init__(self, destinations=[]):
33 self.destinations = set(destinations)
34Method 'countDestinations' is abstract in class 'DatapointRouter' but is not overridden
28 return pickle_loads(data[INT32_SIZE:INT32_SIZE + pickle_size])
29
30
31class BroadcastRouter(DatapointRouter): 32 def __init__(self, destinations=[]):
33 self.destinations = set(destinations)
34
Description
A method marked with @abstractmethod is not defined in the concrete class. This can result in unintended behavior.
It is recommended to implement all abstract methods in the derived classes.
Bad practice
from abc import ABC, abstractmethod
class Vehicle(ABC):
@abstractmethod
def start():
pass
class Car(Vehicle):
# No overridden `start` method here. Can cause unintended behavior
def stop():
self.speed = 0
Recommended
from abc import ABC, abstractmethod
class Vehicle(ABC):
@abstractmethod
def start():
pass
class Car(Vehicle):
def start():
self.speed = 3
def stop():
self.speed = 0