PYL-W0613 · Function contains unused argument

graphite-project / carbon

Active

Function contains unused argument PYL-W0613

Anti-pattern

Major

4 years ago — 4 years old

Unused argument 'result'

262    state.events.cacheFull()
263    log.clients('%s send queue is full (%d datapoints)' % (self, result))
264
265  def queueSpaceCallback(self, result):266    if self.queueFull.called:
267      log.clients('%s send queue has space available' % self.connectedProtocol)
268      self.queueFull = Deferred()

Unused argument 'config'

lib/carbon/service.py

 51      parent.setComponent(ILogObserver, carbonLogObserver)
 52
 53
 54def createBaseService(config, settings): 55    root_service = CarbonRootService()
 56    root_service.setName(settings.program)
 57

Unused argument 'settings'

lib/carbon/service.py

153  return root_service
154
155
156def setupReceivers(root_service, settings):157  from carbon.protocols import MetricReceiver
158
159  for _, plugin_class in MetricReceiver.plugins.items():

Unused argument 'root_service'

lib/carbon/service.py

171  RuleManager.read_from(aggregation_rules_path)
172
173
174def setupRewriterProcessor(root_service, settings):175  from carbon.rewrite import RewriteRuleManager
176
177  rewrite_rules_path = settings["rewrite-rules"]

Unused argument 'timeouts'

lib/carbon/resolver.py

61        """
62        self._nameResolver = nameResolver
63
64    def getHostByName(self, name, timeouts=()):65        """
66        See L{IResolverSimple.getHostByName}
67        @param name: see L{IResolverSimple.getHostByName}

Description

An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.

Bad practice

def square(x, y=1):
    return x * x

class MySubClass(MyClass):
    def __init__(self, number):
        self.value = 42  # argument `number` remains unused

Preferred:

def square(x):
    return x * x

class MySubClass(MyClass):
    def __init__(self, _):
        self.value = 42