Re-definition found for builtin function PYL-W0622
Anti-pattern
Minor
4 years ago
—
4 years old
Redefining built-in 'max'
31 stats[stat] = increase
32
33
34def max(stat, newval): 35 try:
36 if stats[stat] < newval:
37 stats[stat] = newval
Description
Defining a local variable or function with the same name as a built-in object makes the built-in object unusable within the current scope and makes the code prone to bugs.
Bad practice
dict = {} # dict is a Python builtin!
for idx, student in enumerate(students):
dict[student] = idx
Preferred:
roll_number = {}
for idx, student in enumerate(students):
roll_number[student] = idx