Unused argument 'old_value'
174
175@event.listens_for(AccountMembership.is_owner, 'set')
176def _ensure_owner_is_admin_too(
177 target: AccountMembership, value: Any, old_value: Any, _initiator: Any178) -> None:
179 if value:
180 target.is_admin = True
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42