Re-definition found for builtin function PYL-W0622
Anti-pattern
Minor
4 years ago
—
4 years old
Redefining built-in 'sum'
623 current_sem = Semester.objects.get(current_semester=True)
624 transcript = Transcript.objects.get(
625 student=student_info.student, semester=current_sem)
626 sum = 0627 count = 0
628 last_course_being_final = True
629 results = transcript.course_result.all()Redefining built-in 'format'
59class SemesterStart(BaseFacultyLoginView):
60
61 @swagger_auto_schema(request_body=SemesterSerializer)
62 def post(self, request, format=None): 63 print(request.data)
64 # add_semesterCore('Spring2020', semester_season, semester_year, start_date, end_date)
65 return Response(request.data)Redefining built-in 'format'
64 # add_semesterCore('Spring2020', semester_season, semester_year, start_date, end_date)
65 return Response(request.data)
66
67 def delete(self, request, format=None): 68 return Response('Delete Api - Debug')
69
70
Description
Defining a local variable or function with the same name as a built-in object makes the built-in object unusable within the current scope and makes the code prone to bugs.
Bad practice
dict = {} # dict is a Python builtin!
for idx, student in enumerate(students):
dict[student] = idx
Preferred:
roll_number = {}
for idx, student in enumerate(students):
roll_number[student] = idx