if statement can be simplified PYL-R1703
Anti-pattern
Major
a year ago
—
a year old
The if statement can be replaced with 'return bool(test)'
1def for_check(match):
2 try:
3 if 1 <= int(match) <= 100:4 return True
5 else:
6 return False
Description
The highlighted if block can be refactored into a simplified statement, increasing its readability.
Bad practice
def simplifiable_if(arg, arg2):
if arg and not arg2:
var = True
else:
var = False
return var
Recommended
def simplifiable_if(arg, arg2):
var = bool(arg and not arg2)
return var