No default cases in switch statements JS-0047
Anti-pattern
Minor
a year ago
—
a year old
Expected a default case.
85 const message: Message = JSON.parse(event.data);
86 message.parsedContent = JSON.parse(message.content);
87
88 switch (message.parsedContent.code) { 89 case MessageCode.ConnectedSession: 90 this.handleConnectedSession(); 91 break; 92 case MessageCode.DisconnectedSession: 93 this.handleDisconnectedSession(); 94 break; 95 case MessageCode.AllPartiesPresent: 96 this.handleAllPartiesPresent(); 97 break; 98 case MessageCode.ClientInformation: 99 this.handleClientInformation(message.parsedContent.message);100 break;101 case MessageCode.IsPrimaryAccountHolder:102 this.handleIsPrimaryAccountHolder();103 break;104 case MessageCode.DenyGrant:105 this.handleDenyGrant();106 break;107 case MessageCode.InitializeGrantConfirm:108 this.handleInitializeGrantConfirmation();109 break;110 case MessageCode.AccessGrantSuccess:111 this.handleAccessGrantValue(true);112 break;113 case MessageCode.AccessGrantFailure:114 this.handleAccessGrantValue(false);115 break;116 case MessageCode.BadSessionToken:117 this.handleBadSessionToken();118 break;119 case MessageCode.InvalidGrantIdOrToken:120 this.handleInvalidGrantIdOrToken(message.parsedContent);121 }122
123 let data = event.data;
124 if (event.data.sender) {Expected a default case.
67 width: '45em',
68 height: '30em'
69 }
70 switch (context) {71 case GrantsContext.Guest:72 this.matDialog.open(GrantsGuestModalComponent, config);73 break;74 case GrantsContext.Parent:75 this.matDialog.open(GrantsParentModalComponent, config);76 break;77 }78 }
79
80 public openUserListDialog() {
Description
Some code conventions require that all switch statements have a default case, even if the default case is empty. The idea is to always explicitly state what the default behavior should be so that it's clear that the developer didn't forget to handle the default fallback case.
Bad Practice
switch (a) {
case 1:
/* code */
break;
}
Recommended
switch (a) {
case 1:
/* code */
break;
default:
/* code */
break;
}
switch (a) {
case 1:
/* code */
break;
// no default
}
switch (a) {
case 1:
/* code */
break;
// No Default
}