Require template literals instead of string concatenation JS-0246
Anti-pattern
Minor
a year ago
—
a year old
Unexpected string concatenation.
122
123 let data = event.data;
124 if (event.data.sender) {
125 data = event.data.sender + ": " + data;126 }
127 this.messages.push(data);
128 }Unexpected string concatenation.
16
17 for (; i < totalLines; i++) {
18 lineNumber++;
19 lineId = 'line' + lineNumber;20 lines[i].id = lineId;
21 if (lineId === anchorHash) {
22 lines[i].className += ' selected';Unexpected string concatenation.
39
40 public cleanBrowser(userAgent: string) {
41 if (userAgent?.length > 15) {
42 return userAgent.substring(0, 15) + '...';43 }
44 return userAgent;
45 }
Description
In ES2015 (ES6), we can use template literals instead of string concatenation.
var str = `Hello, ${name}!`;
Bad Practice
var str = "Hello, " + name + "!";
var str = "Time: " + (12 * 60 * 60 * 1000);
Recommended
var str = "Hello World!";
var str = `Hello, ${name}!`;
var str = `Time: ${12 * 60 * 60 * 1000}`;
var str = "Hello, " + "World!";