Redundant type in variable declaration GO-C5001
Style
Major
6 months ago
—
a year old
should omit type int from declaration; it will be inferred from the right-hand side
61 }
62
63 var min int = int(math.Pow10(size - 1))
64 var max int = int(math.Pow10(size)) - 1 65
66 return f.IntBetween(min, max)
67}should omit type int from declaration; it will be inferred from the right-hand side
60 return f.RandomDigit()
61 }
62
63 var min int = int(math.Pow10(size - 1)) 64 var max int = int(math.Pow10(size)) - 1
65
66 return f.IntBetween(min, max)should omit type Person from declaration; it will be inferred from the right-hand side
195func (a Address) StreetName() string {
196 street := a.Faker.RandomStringElement(streetNameFormats)
197
198 var p Person = a.Faker.Person()199
200 // {{firstName}}
201 street = strings.Replace(street, "{{firstName}}", p.FirstName(), 1)should omit type Person from declaration; it will be inferred from the right-hand side
177 // {{cityPrefix}}
178 city = strings.Replace(city, "{{cityPrefix}}", a.CityPrefix(), 1)
179
180 var p Person = a.Faker.Person()181
182 // {{firstName}}
183 city = strings.Replace(city, "{{firstName}}", p.FirstName(), 1)
Description
Go infers the types of the variables if the type is not written explicitly. It is recommended to remove the type in the declaration for succinctness.
Bad practice
package main
var foo int = 10
Recommended
package main
var foo = 10