Consider using literal syntax to create the data structure PTC-W0019
Performance
Minor
4 months ago
—
4 years old
unnecessary
dict call - write as literal 179 self.model_lookups_types = dict()
180 self.model_lookups_field_types = dict()
181 self.model_lookups_relationship_types = dict()
182 self.model_sort_types = dict() 183
184 def get_queryset(self, request, Model, only_columns=None):
185 mapper = inspect(Model)unnecessary
dict call - write as literal 178 self.model_filters_relationship_types = dict()
179 self.model_lookups_types = dict()
180 self.model_lookups_field_types = dict()
181 self.model_lookups_relationship_types = dict() 182 self.model_sort_types = dict()
183
184 def get_queryset(self, request, Model, only_columns=None):unnecessary
dict call - write as literal 177 self.model_filters_field_types = dict()
178 self.model_filters_relationship_types = dict()
179 self.model_lookups_types = dict()
180 self.model_lookups_field_types = dict() 181 self.model_lookups_relationship_types = dict()
182 self.model_sort_types = dict()
183unnecessary
dict call - write as literal 176 self.model_filters_types = dict()
177 self.model_filters_field_types = dict()
178 self.model_filters_relationship_types = dict()
179 self.model_lookups_types = dict() 180 self.model_lookups_field_types = dict()
181 self.model_lookups_relationship_types = dict()
182 self.model_sort_types = dict()unnecessary
dict call - write as literal 175 self.relationships_by_clean_name = dict()
176 self.model_filters_types = dict()
177 self.model_filters_field_types = dict()
178 self.model_filters_relationship_types = dict() 179 self.model_lookups_types = dict()
180 self.model_lookups_field_types = dict()
181 self.model_lookups_relationship_types = dict()
Description
Using the literal syntax can give minor performance bumps compared to using function calls to create dict, list and tuple.
In [1]: timeit.timeit(stmt="dict()", number=100000000)
Out[1]: 9.560388602000103
In [2]: timeit.timeit(stmt="{}", number=100000000)
Out[2]: 1.685333584000091
In [3]: timeit.timeit(stmt="tuple()", number=100000000)
Out[3]: 4.509182139000131
In [4]: timeit.timeit(stmt="()", number=100000000)
Out[4]: 0.5455615430000762
In [5]: timeit.timeit(stmt="list()", number=100000000)
Out[5]: 7.356000728000254
In [6]: timeit.timeit(stmt="[]", number=100000000)
Out[6]: 1.573771306999788
This is because here, the name dict must be looked up in the global scope in case it has been rebound.
Same goes for the other two types list() and tuple().