with statements can be merged PTC-W0062
Anti-pattern
Major
6 months ago
—
a year old
Consider merging collapsible
With statements` 66 connection = get_request_connection(request)
67 draft = bool(request.get_argument('draft', False))
68
69 with store.session() as session: 70 with session.begin():
71 for item in self.validated_data:
72 set_overrides = sorted(item['relations'], key=lambda x: x['name'])
Description
Nested with statements can be merged into a single compound with statement.
This issue is raised only when there are no other statements between the nested with statements.
Merging collapsible with statements can decrease cognitive complexity, improving code readability.
Bad practice
with open("file1", "w") as file1:
with open("file2", "w") as file2:
doSomething()
Preferred
with open("file1", "w") as file1, open("file2", "w") as file2:
doSomething()