Consider iterating dictionary PYL-C0201
Anti-pattern
Major
6 months ago
—
2 years old
Consider iterating the dictionary directly instead of calling .keys()
134 except Exception:
135 pass
136
137 unresolved = list(filter(lambda x: x not in instances.keys(), unresolved))138
139 if len(unresolved):
140 token_prefix = 'Token '
Description
Consider iterating the dictionary directly instead of calling .keys().
Using for key in dictionary would always iterate the dictionary keys.
Bad practice
sounds = {"cow": "moo", "dog": "bark"}
for key in sounds.keys():
print(key)
Recommended
sounds = {"cow": "moo", "dog": "bark"}
for key in sounds:
print(key)