Comparison with itself PYL-R0124
Anti-pattern
Major
6 months ago
—
a year old
Redundant comparison - draft == draft
216 with store.session() as session:
217 overrides = session.query(ModelRelationOverrideModel).filter(
218 ModelRelationOverrideModel.connection_id == connection['id'],
219 draft == draft 220 ).all()
221
222 for override in overrides:Redundant comparison - draft == draft
366 with store.session() as session:
367 overrides = session.query(ModelRelationOverrideModel).filter(
368 ModelRelationOverrideModel.connection_id == connection['id'],
369 draft == draft370 ).all()
371
372 for override in overrides:Redundant comparison - draft == draft
74 existing_overrides = session.query(ModelRelationOverrideModel).filter(
75 ModelRelationOverrideModel.connection_id == connection['id'],
76 ModelRelationOverrideModel.model == item['model'],
77 draft == draft 78 ).order_by(ModelRelationOverrideModel.name).all()
79 existing_overrides = list(existing_overrides)
80
Description
Comparison of an object with itself always returns True.
This is redundant.
Bad practice
if x >= x:
y = square(x)
if y != y:
y = 0
return y
Recommended
y = square(x)
return y