Abstract method not overridden PYL-W0223
Bug risk
Major
3 months ago
—
4 years old
Method 'create' is abstract in class 'Serializer' but is not overridden in child class 'SqlsSerializer'
390 session.close()
391
392
393class SqlsSerializer(Serializer):394 queries = SqlSerializer(many=True)
395
396 def execute(self, data):Method 'update' is abstract in class 'Serializer' but is not overridden in child class 'SqlsSerializer'
390 session.close()
391
392
393class SqlsSerializer(Serializer):394 queries = SqlSerializer(many=True)
395
396 def execute(self, data):Method 'update' is abstract in class 'Serializer' but is not overridden in child class 'SqlSerializer'
55 yFunc = fields.CharField()
56
57
58class SqlSerializer(Serializer): 59 query = fields.CharField()
60 offset = fields.IntegerField(required=False)
61 limit = fields.IntegerField(required=False)Method 'create' is abstract in class 'Serializer' but is not overridden in child class 'SqlSerializer'
55 yFunc = fields.CharField()
56
57
58class SqlSerializer(Serializer): 59 query = fields.CharField()
60 offset = fields.IntegerField(required=False)
61 limit = fields.IntegerField(required=False)Method 'create' is abstract in class 'Serializer' but is not overridden in child class 'GroupsSerializer'
49 xLookup = fields.CharField(required=False)
50
51
52class GroupsSerializer(Serializer): 53 xColumns = GroupsItemSerializer(many=True)
54 yColumn = fields.CharField(required=False)
55 yFunc = fields.CharField()
Description
A method marked with @abstractmethod is not defined in the concrete class. This can result in unintended behavior.
It is recommended to implement all abstract methods in the derived classes.
Bad practice
from abc import ABC, abstractmethod
class Vehicle(ABC):
@abstractmethod
def start():
pass
class Car(Vehicle):
# No overridden `start` method here. Can cause unintended behavior
def stop():
self.speed = 0
Recommended
from abc import ABC, abstractmethod
class Vehicle(ABC):
@abstractmethod
def start():
pass
class Car(Vehicle):
def start():
self.speed = 3
def stop():
self.speed = 0