Global variable is declared but not used PYL-W0602
Bug risk
Major
6 months ago
—
2 years old
Using global for 'connections' but no assignment is done
672
673
674def dispose_connection(conf):
675 global connections676
677 connection_id = get_connection_id(conf)
678 connection = connections.get(connection_id)Using global for 'pending_connections' but no assignment is done
421
422
423def connect_database(conf):
424 global connections, pending_connections425
426 connection_id = get_connection_id(conf)
427 connection_params_id = get_connection_params_id(conf)Using global for 'connections' but no assignment is done
421
422
423def connect_database(conf):
424 global connections, pending_connections425
426 connection_id = get_connection_id(conf)
427 connection_params_id = get_connection_params_id(conf)
Description
The variable is defined through the global statement but no assignment to this variable is done. It is recommended to remove it if not necessary.
Bad practice
def my_func():
global a
return a
Recommended
If it is a newly defined global, make sure to assign a value to it.
def my_func():
global a
a = 1 # Assign to the newly defined global value.
return a
Or if the global should be already defined, you can remove the global statement.
a = 1
def my_func():
return a # The global statement can be removed
Note: DeepSource will remove the global statement during autofix.