Unused variable found PYL-W0612
Anti-pattern
Major
6 months ago
—
4 years old
Unused variable 'dirpath'
95 directories = []
96 files = []
97
98 for dirpath, dirnames, filenames in os.walk(absolute_path): 99 directories.extend(dirnames)
100 files.extend(filenames)
101Unused variable 'metadata'
211 return JSONResponse(status=status.HTTP_204_NO_CONTENT)
212
213 def perform_destroy(self, request, column):
214 metadata, engine = self.get_db(request)215 table = self.get_table(request)
216
217 ddl_compiler = engine.dialect.ddl_compiler(engine.dialect, None)Unused variable 'engine'
167 return JSONResponse(columns)
168
169 def retrieve(self, request, *args, **kwargs):
170 metadata, engine = self.get_db(request)171 instance = self.get_object(request)
172 table = instance.table
173 return JSONResponse(map_table_column(metadata, table, instance, True))Unused variable 'engine'
161 return obj
162
163 def list(self, request, *args, **kwargs):
164 metadata, engine = self.get_db(request)165 table = self.get_table(request)
166 columns = list(map(lambda x: map_table_column(metadata, table, x, True), table.columns))
167 return JSONResponse(columns)Unused variable 'engine'
142 return obj
143
144 def get_object(self, request):
145 metadata, engine = self.get_db(request)146 table_name = request.path_kwargs['table']
147
148 try:
Description
An unused variable takes up space in the code, and can lead to confusion, and it should be removed. If this variable is necessary, name the variable _ to indicate that it will be unused, or start the name with unused or _unused.
Bad practice
def update():
for i in range(10): # Usused variable `i`
time.sleep(0.01)
display_result()
Preferred:
def update():
for _ in range(10):
time.sleep(0.01)
display_result()