Function contains unused argument PYL-W0613
Anti-pattern
Major
8 days ago
—
4 years old
Unused argument 'filters_instance'
172 )
173 filters_instances.append(instance)
174
175 def get_filter_value(name, filters_instance=None):176 filter_items = list(filter(lambda x: x['name'] == name, data.get('filters', [])))
177
178 if not len(filter_items):Unused argument 'filters_instance'
50 self.filters = filters
51
52 def filter_queryset(self, request, queryset):
53 def get_filter_value(name, filters_instance=None):54 return request.get_argument_safe(name, None)
55
56 for item in self.filters:Unused argument 'queryset'
117 return is_null(queryset, column, value)
118
119
120def coveredby(queryset, column, value):121 return column.ST_CoveredBy(value)
122
123Unused argument 'queryset'
98 return column.astext.ilike('%{}%'.format(value))
99
100
101def is_null(queryset, column, value):102 if value:
103 return column.__eq__(None)
104 else:Unused argument 'queryset'
89 return column.ilike('%{}%'.format(value))
90
91
92def json_icontains(queryset, column, value): 93 field_type = column.property.columns[0].type if hasattr(column, 'property') else column.type
94
95 if is_instance_or_subclass(field_type, (sqltypes.JSON, sqltypes.NullType)) or not hasattr(column, 'astext'):
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42