Re-defined variable from outer scope PYL-W0621
Anti-pattern
Major
3 months ago
—
4 years old
Redefining name 'column' from outer scope (line 5)
357
358 type_code_to_sql_type = get_type_code_to_sql_type(request)
359 if type_code_to_sql_type:
360 def map_column_description(column):361 name = column.name if hasattr(column, 'name') else ''
362 sql_type = type_code_to_sql_type.get(column.type_code) if hasattr(column, 'type_code') else None
363 return name, {Redefining name 'lookups' from outer scope (line 11)
983 })
984
985 def create_list_resolver(Model, mapper):
986 def resolver(parent, info, filters=None, lookups=None, sort=None, pagination=None, search=None): 987 request = info.context.get('request')
988
989 if before_resolve is not None:Redefining name 'lookups' from outer scope (line 11)
854
855 i += 1
856
857 def resolve_model_list(self, MappedBase, Model, mapper,info, filters=None, lookups=None, sort=None, pagination=None, search=None): 858 try:
859 filters = filters or []
860 lookups = lookups or []Redefining name 'ModelAttrsType' from outer scope (line 54)
971 FiltersType = self.get_model_filters_type(MappedBase, mapper)
972 LookupsType = self.get_model_lookups_type(MappedBase, mapper)
973 SortType = self.get_model_sort_type(MappedBase, mapper)
974 ModelAttrsType = self.get_model_attrs_type(MappedBase, mapper) 975 ModelType = type('Model{}ModelType'.format(name), (graphene.ObjectType,), {
976 'attrs': graphene.Field(ModelAttrsType),
977 'allAttrs': graphene.Field(RawScalar),Redefining name 'lookups' from outer scope (line 11)
437
438 return queryset
439
440 def get_models_lookups(self, request, MappedBase, models, Model, mapper, lookups): 441 result = []
442
443 for lookup_item in lookups:
Description
The local variable name hides the variable defined in the outer scope, making it inaccessible and might confuse.
Bad practice
filename = 'myfile.txt'
def read_file(filename): # This shadows the global `filename`
with open(filename) as file:
return file.readlines()
Preferred:
FILENAME = 'myfile.txt' # renamed global to UPPER_CASE as convention
def read_file(filename):
with open(filename) as file:
return file.readlines()
Bad practice
Another usual suspect of this is when you use the same parameter name inside a function as the global variable you are using. For example:
def run_app(app):
# This `app` shadows the global app...
app.run()
if __name__ == '__main__':
app = MyApp() # This is a global variable!
run_app(app)
Preferred:
To avoid this re-defining of a global, consider not defining app as a global, but inside a main() function instead:
def run_app(app):
# There is no longer a global `app` variable.
app.run()
def main():
app = MyApp()
run_app(app)
if __name__ == '__main__':
main()