PYL-W0703 · Exception caught is very general

jet-admin / jet-bridge

Active

Exception caught is very general PYL-W0703

Anti-pattern

Major

6 months ago — 4 years old

Catching too general exception Exception

packages/jet_django/jet_django/router.py

 41                        inner_self.before_dispatch(request)
 42                        response = inner_self.view.dispatch(action, request, *args, **kwargs)
 43                        return inner_self.write_response(response)
 44                    except Exception: 45                        exc_type, exc, traceback = sys.exc_info()
 46                        response = inner_self.view.error_response(request, exc_type, exc, traceback)
 47                        return inner_self.write_response(response)

Catching too general exception Exception

packages/jet_bridge_base/jet_bridge_base/utils/track_model.py

45        if not success:
46            error = 'MODEL_CHANGE request error: {} {} {}'.format(r.status_code, r.reason, r.text)
47            sentry_controller.capture_message(error)
48    except Exception as e:49        sentry_controller.capture_exception(e)
50
51

Catching too general exception Exception

packages/jet_bridge_base/jet_bridge_base/utils/track_database.py

35        if not success:
36            error = 'TRACK_DATABASE request error: {} {} {}'.format(r.status_code, r.reason, r.text)
37            sentry_controller.capture_message(error)
38    except Exception as e:39        sentry_controller.capture_exception(e)
40
41

Catching too general exception Exception

packages/jet_bridge/jet_bridge/router.py

 51                    try:
 52                        response = yield as_future(execute)
 53                        yield inner_self.write_response(response)
 54                    except Exception: 55                        exc_type, exc, traceback = sys.exc_info()
 56                        response = inner_self.view.error_response(request, exc_type, exc, traceback)
 57                        yield inner_self.write_response(response)

Catching too general exception Exception

packages/jet_bridge/jet_bridge/handlers/view.py

133        try:
134            response = yield as_future(execute)
135            yield self.write_response(response)
136        except Exception:137            exc_type, exc, traceback = sys.exc_info()
138            response = self.view.error_response(request, exc_type, exc, traceback)
139            yield self.write_response(response)

Description

If the except block catches a very general exception, it is likely to catch any unrelated errors too. Try to be more explicit about which exception(s) you're trying to catch.

If you need to catch every other exception, then mark it as intentional by adding a # skipcq comment.

Bad practice

try:
    x = a / b
except Exception:
    x = a / (b + 1)

try:
    line = input('Enter numbers:')
    numbers = [int(i) for i in line.split()]
except BaseException:
    print('Only use numbers for the input')

Preferred:

try:
    x = a / b
except ZeroDivisionError:
    x = a / (b + 1)

try:
    event_loop.run()
except Exception as exc:  # skipcq: PYL-W0703 - Loop can sometimes crash.
    sentry.report(exc)

try:
    line = input('Enter numbers:')
    numbers = [int(i) for i in line.split()]
except ValueError:
    print('Only use numbers for the input')