Lazy formatting of message string passed to logging module PYL-W1202
Performance
Minor
6 days ago
—
3 months old
Use lazy % formatting in logging functions
103 for rule in reversed(map_data_types):
104 if is_instance_or_subclass(value, rule['sql_type']):
105 return rule.get('convert')
106 logger.warning('Unknown database type: {}'.format(str(value)))Use lazy % formatting in logging functions
96 for rule in map_data_types:
97 if rule['db_type'] == value:
98 return rule.get('convert')
99 logger.warning('Unknown database type: {}'.format(str(value)))100
101
102def get_sql_type_convert(value):Use lazy % formatting in logging functions
88 for rule in map_data_types:
89 if rule['db_type'] == value:
90 return rule['sql_type']
91 logger.warning('Unknown database type: {}'.format(str(value))) 92 return default_sql_type
93
94Use lazy % formatting in logging functions
80 for rule in reversed(map_data_types):
81 if is_instance_or_subclass(value, rule['sql_type']):
82 return rule['db_type']
83 logger.warning('Unknown database type: {}'.format(str(value))) 84 return default_db_type
85
86Use lazy % formatting in logging functions
72 for rule in map_data_types:
73 if rule['map_type'] == value:
74 return rule['sql_type']
75 logger.warning('Unknown database type: {}'.format(str(value))) 76 return default_sql_type
77
78
Description
Formatting the message manually before passing it to a logging call does unnecessary work if logging in disabled. Consider using the logging module's built-in formatting features to avoid that.
Bad practice
import logging, inspect
logging.basicConfig(level=logging.INFO)
logging.debug("Entered function {}".format(inspect.stack[0][3]))
Recommended
import logging, inspect
logging.basicConfig(level=logging.INFO)
logging.debug("Entered function %s", inspect.stack[0][3])