Misplaced comparison constant PYL-C2201
Style
Major
a year ago
—
a year old
Comparison should be new_level >= 15
61 @staticmethod
62 def assess_new_roles(new_level, db):
63 roles_to_add = []
64 if 15 <= new_level: 65 roles_to_add.append(db.role_memberplus)
66 if 30 <= new_level:
67 roles_to_add.append(db.role_memberpro)Comparison should be new_level >= 30
63 roles_to_add = []
64 if 15 <= new_level:
65 roles_to_add.append(db.role_memberplus)
66 if 30 <= new_level: 67 roles_to_add.append(db.role_memberpro)
68 if 50 <= new_level:
69 roles_to_add.append(db.role_memberedition)Comparison should be new_level >= 75
67 roles_to_add.append(db.role_memberpro)
68 if 50 <= new_level:
69 roles_to_add.append(db.role_memberedition)
70 if 75 <= new_level: 71 roles_to_add.append(db.role_memberone)
72 if 100 <= new_level:
73 roles_to_add.append(db.role_memberultra)Comparison should be new_level >= 100
69 roles_to_add.append(db.role_memberedition)
70 if 75 <= new_level:
71 roles_to_add.append(db.role_memberone)
72 if 100 <= new_level: 73 roles_to_add.append(db.role_memberultra)
74
75 return roles_to_addComparison should be new_level >= 50
65 roles_to_add.append(db.role_memberplus)
66 if 30 <= new_level:
67 roles_to_add.append(db.role_memberpro)
68 if 50 <= new_level: 69 roles_to_add.append(db.role_memberedition)
70 if 75 <= new_level:
71 roles_to_add.append(db.role_memberone)
Description
The constant is placed on the left side of a comparison. It is usually clearer in intent to place it in the right hand side of the comparison.
Bad practice
if 0 == x % 2:
...
Recommended:
if x % 2 == 0:
...