Unnecessary use of comprehension PYL-R1721
Performance
Major
a year ago
—
a year old
Unnecessary use of a comprehension, use list(self.join_overtime_mapping.get(timestamp)) instead.
153 timestamp)
154 current = member.joined_at.replace(tzinfo=timezone.utc).timestamp()
155 if bucket.update_rate_limit(current):
156 users = [m for m in self.join_overtime_mapping.get(timestamp)]157 for user in users:
158 try:
159 await self.raid_ban(user, reason=f"Join spam over time detected (bucket `{timestamp_bucket_for_logging}`)", dm_user=True)Unnecessary use of a comprehension, use list(interaction.client.issue_cache.cache) instead.
204
205
206async def issue_autocomplete(interaction: discord.Interaction, current: str) -> List[app_commands.Choice[str]]:
207 issue_titles = [issue for issue in interaction.client.issue_cache.cache]208 issue_titles.sort(key=lambda issue: issue.lower())
209 return [app_commands.Choice(name=issue_title, value=issue_title) for issue_title in issue_titles if current.lower() in issue_title.lower()][:25]
210
Description
It is unnecessary to use a comprehension just to loop over the iterable and create a list/set/dict out of it.
Python has a specialized set of tools for this task: the list/set/dict constructors, which are faster and more readable.
Bad practice
states = [
('AL', 'Alabama'),
('AK', 'Alaska'),
('AZ', 'Arizona'),
('AR', 'Arkansas'),
('CA', 'California'),
# ...
]
abbreviations_to_names = {
abbreviation: name
for abbreviation, name in states
}
Recommended
states = [
('AL', 'Alabama'),
('AK', 'Alaska'),
('AZ', 'Arizona'),
('AR', 'Arkansas'),
('CA', 'California'),
# ...
]
abbreviations_to_names = dict(states)