Re-definition found for builtin function PYL-W0622
Anti-pattern
Major
a year ago
—
a year old
Redefining built-in 'input'
8from utils.framework import gatekeeper
9
10
11def find_triggered_filters(input, member: discord.Member) -> List[FilterWord]:12 """
13 BAD WORD FILTER
14 """Redefining built-in 'input'
50 return words_found
51
52
53def find_triggered_raid_phrases(input, member):54 symbols = (u"абвгдеёжзийклмнопрстуфхцчшщъыьэюяАБВГДЕЁЖЗИЙКЛМНОПРСТУФХЦЧШЩЪЫЬЭЮЯ",
55 u"abBrdeex3nnKnmHonpcTyoxu4wwbbbeoRABBrDEEX3NNKNMHONPCTyOXU4WWbbbEOR")
56Redefining built-in 'type'
116}
117
118
119def determine_emoji(type):120 emoji_dict = {
121 "KICK": "👢",
122 "BAN": "❌",
Description
Defining a local variable or function with the same name as a built-in object makes the built-in object unusable within the current scope and makes the code prone to bugs.
Bad practice
dict = {} # dict is a Python builtin!
for idx, student in enumerate(students):
dict[student] = idx
Preferred:
roll_number = {}
for idx, student in enumerate(students):
roll_number[student] = idx