Validation of JSX maximum depth JS-0415
Expected the depth of nested jsx elements to be <= 2, but found 3
31 </div>
32 <div className="login-card-footer">
33 <button className="custom-button">Login</button>
34 <a href="#" className={"forgot"}>Forgot username or password?</a>35 </div>
36
37 </div>Expected the depth of nested jsx elements to be <= 2, but found 3
30 </div>
31 </div>
32 <div className="login-card-footer">
33 <button className="custom-button">Login</button>34 <a href="#" className={"forgot"}>Forgot username or password?</a>
35 </div>
36Expected the depth of nested jsx elements to be <= 2, but found 4
26 </div>
27 <div className="field-container">
28 <input className="field-input" id="password" name="password" type="password" placeholder=" "/>
29 <label className="field-placeholder" htmlFor="password">Password</label>30 </div>
31 </div>
32 <div className="login-card-footer">Expected the depth of nested jsx elements to be <= 2, but found 4
25 <label className="field-placeholder" htmlFor="username">Username</label>
26 </div>
27 <div className="field-container">
28 <input className="field-input" id="password" name="password" type="password" placeholder=" "/>29 <label className="field-placeholder" htmlFor="password">Password</label>
30 </div>
31 </div>Expected the depth of nested jsx elements to be <= 2, but found 4
22 <div className="login-card-body">
23 <div className="field-container">
24 <input className="field-input" id="username" name="username" type="text" placeholder=" "/>
25 <label className="field-placeholder" htmlFor="username">Username</label>26 </div>
27 <div className="field-container">
28 <input className="field-input" id="password" name="password" type="password" placeholder=" "/>
Description
Nesting JSX elements too deeply can confuse developers reading the code. To make maintenance and refactoring easier, DeepSource recommends limiting the maximum JSX tree depth to 4.
Code that looks like this is nearly unreadable for someone unfamiliar:
function App() {
return <Foo>
<Bar>
<Baz>
<div id="deep-div">
Too deeply nested!
</div>
</Baz>
</Bar>
</Foo>
}
Bad Practice
function FormContainer() {
// This JSX tree is too deep
return <FormWrapper>
<Form>
<FormEntry>
<Label>
<strong>Name</strong>
</Label>
<FormInput type="text" / >
</FormEntry>
</Form>
</FormWrapper>
}
Recommended
function FormContainer() {
// the FormEntry component has been modified to accept the labelName and inputType.
// It now returns JSX that contains a label and a field.
return <FormWrapper>
<Form>
<FormEntry labelName="Name" inputType="text">
</FormEntry>
</Form>
</FormWrapper>
}