Missing return statement in method/function PHP-E1004
Bug risk
Critical
2 years ago
—
2 years old
Method App\Http\Middleware\Authenticate::redirectTo() should return string|null but return statement is missing
14 */
15 protected function redirectTo($request)
16 {
17 if (! $request->expectsJson()) {18 return route('login');
19 }
20 }
Description
This issue is raised if a method with a return type does not have a return statement of an appropriate type.
Bad practice
class User
{
public function greet(): string
{
$message = 'Hello, there!';
// missing return statement
}
}
class User
{
public function greet()
{
$message = function (): string {
$message = 'Hello, there!';
// missing return statement
};
return $message();
}
}
Recommended
class User
{
public function greet(): string
{
$message = 'Hello, there!';
return $message;
}
}
class User
{
public function greet()
{
$message = function (): string {
$message = 'Hello, there!';
return $message;
};
return $message();
}
}