Protected member accessed from outside the class PYL-W0212
Bug risk
Minor
3 years ago
—
3 years old
Access to a protected member __country_code of a client class
1613 elif cmd == Packet.Type.pong_ack:
1614 continue
1615 elif cmd == Packet.Type.country_code:
1616 self.__session.__country_code = packet.payload.decode()1617 self.__session.logger.info(
1618 "Received country_code: {}".format(
1619 self.__session.__country_code))Access to a protected member __country_code of a client class
1616 self.__session.__country_code = packet.payload.decode()
1617 self.__session.logger.info(
1618 "Received country_code: {}".format(
1619 self.__session.__country_code))1620 elif cmd == Packet.Type.license_version:
1621 license_version = io.BytesIO(packet.payload)
1622 license_id = struct.unpack(">h",
Description
Accessing a protected member (a member prefixed with _) of a class from outside that class is not recommended, since the creator of that class did not intend this member to be exposed. If accesing this attribute outside of the class is absolutely needed, refactor it such that it becomes part of the public interface of the class.
Bad practice
class Rectangle(object):
def __init__(self, height, width):
self._height = height
self._width = width
r = Rectangle(4, 8)
area = r._height * r._width
Preferred:
class Rectangle(object):
def __init__(self, height, width):
self._height = height
self._width = width
def area():
return self._height * self._width
r = Rectangle(4, 8)
area = r.area()