Abstract method not overridden PYL-W0223
Bug risk
Major
2 years ago
—
3 years old
Method 'close' is abstract in class 'Closeable' but is not overridden
222 .ChunkException("Failed due to stream error, code: {}".format(stream_error))
223
224
225class AudioKeyManager(PacketsReceiver, Closeable):226 audio_key_request_timeout = 20
227 logger = logging.getLogger("Librespot:AudioKeyManager")
228 __callbacks: typing.Dict[int, Callback] = {}Method 'on_request' is abstract in class 'RequestListener' but is not overridden
11import urllib.parse
12
13
14class DeviceStateHandler(Closeable, MessageListener, RequestListener): 15 logger = logging.getLogger("Librespot:DeviceStateHandler")
16 __closing = False
17 __connection_id: str = NoneMethod 'on_message' is abstract in class 'MessageListener' but is not overridden
11import urllib.parse
12
13
14class DeviceStateHandler(Closeable, MessageListener, RequestListener): 15 logger = logging.getLogger("Librespot:DeviceStateHandler")
16 __closing = False
17 __connection_id: str = NoneMethod 'close' is abstract in class 'Closeable' but is not overridden
36import websocket
37
38
39class ApiClient(Closeable): 40 logger = logging.getLogger("Librespot:ApiClient")
41 __base_url: str
42 __session: Session
Description
A method marked with @abstractmethod is not defined in the concrete class. This can result in unintended behavior.
It is recommended to implement all abstract methods in the derived classes.
Bad practice
from abc import ABC, abstractmethod
class Vehicle(ABC):
@abstractmethod
def start():
pass
class Car(Vehicle):
# No overridden `start` method here. Can cause unintended behavior
def stop():
self.speed = 0
Recommended
from abc import ABC, abstractmethod
class Vehicle(ABC):
@abstractmethod
def start():
pass
class Car(Vehicle):
def start():
self.speed = 3
def stop():
self.speed = 0