Exit inside non-main function RVV-A0003
Anti-pattern
Major
2 years ago
—
2 years old
calls to log.Fatalf only in main() or init() functions
46func (app *Application) Start() {
47 log.Println("Starting server on port", app.Config.Port)
48 if err := app.server.ListenAndServe(); err != nil && errors.Is(err, http.ErrServerClosed) {
49 log.Fatalf("Server closed, readon: %v", err)50 }
51}
52calls to log.Fatal only in main() or init() functions
87 // metrics := &models.Gitevent{}
88 data, err := json.Marshal(metrics)
89 if err != nil {
90 log.Fatal(err)91
92 }
93calls to log.Fatalf only in main() or init() functions
54func (app *Application) Start() {
55 log.Println("Starting server on port", app.Config.Port)
56 if err := app.server.ListenAndServe(); err != nil && errors.Is(err, http.ErrServerClosed) {
57 log.Fatalf("Server closed, readon: %v", err)58 }
59}
60calls to log.Fatal only in main() or init() functions
76 Subjects: []string{streamSubjects},
77 })
78 if err != nil {
79 log.Fatal(err) 80 }
81 }
82 return nil
Description
Packages exposing functions that can stop program execution by exiting are hard to reuse. Program exits in functions other than main() or init() are not encouraged.
Bad practice
func nonMainFunc() {
safelyExit := true // somehow arrive at this value
if safelyExit {
os.Exit(0)
}
}
func main() {
nonMainFunc()
}
Recommended
func nonMainFunc() bool {
safelyExit := true // somehow arrive at this value
}
func main() {
safelyExit := nonMainFunc()
if safelyExit {
os.Exit(0)
}
}