Functions prefixed with
Get should return a value RVV-A0006
Anti-pattern
Major
10 months ago
—
10 months old
function 'GetApiDocs' seems to be a getter but it does not return any result
60 c.Status(http.StatusOK)
61}
62
63func (app *Application) GetApiDocs(c *gin.Context) {64 swagger, err := api.GetSwagger()
65 if err != nil {
66 c.AbortWithStatus(http.StatusInternalServerError)function 'GetLiveness' seems to be a getter but it does not return any result
56 }
57 app.conn.Publish(jsonData, repo)
58}
59func (app *Application) GetLiveness(c *gin.Context) {60 c.Status(http.StatusOK)
61}
62
Description
Typically, functions with names prefixed with Get are supposed to return a value.
Bad practice
func GetData(n int) {
fmt.Println(10 - n)
}
Recommended
func GetData(n int) int {
fmt.Println(10 - n)
return 10 - n
}