JS-0125 @ 079b622 • kylerchin / adorabot

Run summary

5 months ago

279bb4c..079b622

35 s

Found the usage of undeclared variables JS-0125

Bug risk

Critical

13 occurrences in this check

'datadogScore' is not defined

bts-stats.js

 54          datadogScore = parseFloat(scoreArray[pollindex].replace("%",""))
 55
 56          dogstatsd.gauge(datadogValue, datadogScore);
 57          console.log(datadogValue + ":" + datadogScore ) 58
 59          
 60          pollindex = pollindex + 1;

'datadogValue' is not defined

bts-stats.js

 54          datadogScore = parseFloat(scoreArray[pollindex].replace("%",""))
 55
 56          dogstatsd.gauge(datadogValue, datadogScore);
 57          console.log(datadogValue + ":" + datadogScore ) 58
 59          
 60          pollindex = pollindex + 1;

'datadogValue' is not defined

bts-stats.js

 53          datadogValue = "bbps."  + ddcatagory + "." + nameArray[pollindex].replace(" ","").replace("\\\"","").replace("\\\"","").replace("[","").replace("]","").replace(" ","").replace(":","").replace(",","").replace(",","").replace(",","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(".","").replace(".","").replace(".","").replace(" ","").replace(" ","").replace(" ","").replace("#","").replace(" ","").replace("*","").replace("-","").replace("-","")
 54          datadogScore = parseFloat(scoreArray[pollindex].replace("%",""))
 55
 56          dogstatsd.gauge(datadogValue, datadogScore); 57          console.log(datadogValue + ":" + datadogScore )
 58
 59

'datadogScore' is not defined

bts-stats.js

 53          datadogValue = "bbps."  + ddcatagory + "." + nameArray[pollindex].replace(" ","").replace("\\\"","").replace("\\\"","").replace("[","").replace("]","").replace(" ","").replace(":","").replace(",","").replace(",","").replace(",","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(".","").replace(".","").replace(".","").replace(" ","").replace(" ","").replace(" ","").replace("#","").replace(" ","").replace("*","").replace("-","").replace("-","")
 54          datadogScore = parseFloat(scoreArray[pollindex].replace("%",""))
 55
 56          dogstatsd.gauge(datadogValue, datadogScore); 57          console.log(datadogValue + ":" + datadogScore )
 58
 59

'datadogScore' is not defined

bts-stats.js

 51          //
 52
 53          datadogValue = "bbps."  + ddcatagory + "." + nameArray[pollindex].replace(" ","").replace("\\\"","").replace("\\\"","").replace("[","").replace("]","").replace(" ","").replace(":","").replace(",","").replace(",","").replace(",","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(".","").replace(".","").replace(".","").replace(" ","").replace(" ","").replace(" ","").replace("#","").replace(" ","").replace("*","").replace("-","").replace("-","")
 54          datadogScore = parseFloat(scoreArray[pollindex].replace("%","")) 55
 56          dogstatsd.gauge(datadogValue, datadogScore);
 57          console.log(datadogValue + ":" + datadogScore )

'scoreArray' is not defined

bts-stats.js

 51          //
 52
 53          datadogValue = "bbps."  + ddcatagory + "." + nameArray[pollindex].replace(" ","").replace("\\\"","").replace("\\\"","").replace("[","").replace("]","").replace(" ","").replace(":","").replace(",","").replace(",","").replace(",","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(".","").replace(".","").replace(".","").replace(" ","").replace(" ","").replace(" ","").replace("#","").replace(" ","").replace("*","").replace("-","").replace("-","")
 54          datadogScore = parseFloat(scoreArray[pollindex].replace("%","")) 55
 56          dogstatsd.gauge(datadogValue, datadogScore);
 57          console.log(datadogValue + ":" + datadogScore )

'datadogValue' is not defined

bts-stats.js

 50         // pollResultsFinalArray.push(nextLinePoll)
 51          //
 52
 53          datadogValue = "bbps."  + ddcatagory + "." + nameArray[pollindex].replace(" ","").replace("\\\"","").replace("\\\"","").replace("[","").replace("]","").replace(" ","").replace(":","").replace(",","").replace(",","").replace(",","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(".","").replace(".","").replace(".","").replace(" ","").replace(" ","").replace(" ","").replace("#","").replace(" ","").replace("*","").replace("-","").replace("-","") 54          datadogScore = parseFloat(scoreArray[pollindex].replace("%",""))
 55
 56          dogstatsd.gauge(datadogValue, datadogScore);

'nameArray' is not defined

bts-stats.js

 50         // pollResultsFinalArray.push(nextLinePoll)
 51          //
 52
 53          datadogValue = "bbps."  + ddcatagory + "." + nameArray[pollindex].replace(" ","").replace("\\\"","").replace("\\\"","").replace("[","").replace("]","").replace(" ","").replace(":","").replace(",","").replace(",","").replace(",","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(" ","").replace(".","").replace(".","").replace(".","").replace(" ","").replace(" ","").replace(" ","").replace("#","").replace(" ","").replace("*","").replace("-","").replace("-","") 54          datadogScore = parseFloat(scoreArray[pollindex].replace("%",""))
 55
 56          dogstatsd.gauge(datadogValue, datadogScore);

'nameArray' is not defined

bts-stats.js

 45
 46        var pollResultsFinalArray = []
 47
 48        nameArray.forEach(message => { 49          //var nextLinePoll = nameArray[pollindex] + " : " + scoreArray[pollindex]
 50         // pollResultsFinalArray.push(nextLinePoll)
 51          //

'scoreArray' is not defined

bts-stats.js

 33      $(this).find(".pds-feedback-per").each(function (i,row) {
 34        var scoreAnswer = row.innerHTML.replace("&nbsp;","")
 35      //console.log(nameAnswer)
 36    scoreArray.push(scoreAnswer) 37    })
 38        })
 39

'nameArray' is not defined

bts-stats.js

 27        $(this).find(".pds-answer-text").each(function (i,row) {
 28          var nameAnswer = row.innerHTML
 29        console.log(nameAnswer)
 30      nameArray.push(nameAnswer) 31      })
 32
 33      $(this).find(".pds-feedback-per").each(function (i,row) {

'scoreArray' is not defined

bts-stats.js

 19
 20        var $content = $(output1);
 21        nameArray = []
 22        scoreArray = [] 23
 24       $content.each( function () {
 25        //console.log("hi");

'nameArray' is not defined

bts-stats.js

 18        //document.getElementById("parse").innerHTML = output1;
 19
 20        var $content = $(output1);
 21        nameArray = [] 22        scoreArray = []
 23
 24       $content.each( function () {

Description

Variables that aren't defined, but accessed may throw reference errors at runtime.

NOTE: In browser applications, DeepSource recommends the use of ESModules over regular text/javascript scripts. Using variables that are injected by scripts included in an HTML file is currently not supported.

Potential ReferenceErrors may result from misspellings of variable and parameter names, or accidental implicit globals (for example, forgetting the var keyword in a for loop initializer). Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment, or specified in the globals key in the ESLint configuration file. A common use case for these is if you intentionally use globals that are defined elsewhere (e.g. in a script sourced from HTML).

Bad Practice

const foo = someFunction(); // `someFunction` is not defined
const bar = baz + 1; // 'baz' is undeclared

kylerchin / adorabot

Bad Practice

Recommended