JS-0359 @ 079b622 • kylerchin / adorabot

Run summary

5 months ago

279bb4c..079b622

35 s

Detected the use of require statements except in import statements JS-0359

Anti-pattern

Major

135 occurrences in this check

Require statement not part of import statement

testytkeysinbun.ts

 2 
 3import axios from 'axios'; 
 4 
 5const  {config} = require('./config.json');  6   
 7 
 8

Require statement not part of import statement

src/youtubeviewcountdaemon.ts

 16const loadedRemovedData = importconfigfile.get()
 17const loadedAuthData = authconfigfile.get()
 18
 19const Long = require('cassandra-driver').types.Long; 20
 21function randomIntFromInterval(min, max) { // min and max included 
 22    return Math.floor(Math.random() * (max - min + 1) + min)

Require statement not part of import statement

src/youtubeviewcountdaemon.ts

  4const TimeUuid = require('cassandra-driver').types.TimeUuid;
  5const editJsonFile = require("edit-json-file");
  6import { Client } from "youtubei";
  7const requestjson = require('request-json');  8import {simpleHash} from './modules/simplehash'
  9import {dogstatsd} from './modules/dogstats';
 10

Require statement not part of import statement

src/youtubeviewcountdaemon.ts

  2import {cassandraclient} from './modules/cassandraclient'
  3import {logger} from './modules/logger'
  4const TimeUuid = require('cassandra-driver').types.TimeUuid;
  5const editJsonFile = require("edit-json-file");  6import { Client } from "youtubei";
  7const requestjson = require('request-json');
  8import {simpleHash} from './modules/simplehash'

Require statement not part of import statement

src/youtubeviewcountdaemon.ts

  1
  2import {cassandraclient} from './modules/cassandraclient'
  3import {logger} from './modules/logger'
  4const TimeUuid = require('cassandra-driver').types.TimeUuid;  5const editJsonFile = require("edit-json-file");
  6import { Client } from "youtubei";
  7const requestjson = require('request-json');

Require statement not part of import statement

src/updatesafebrowsingdatabase.ts

  6const cassandra = require('cassandra-driver');
  7var axios = require('axios');
  8
  9var forEach = require("for-each") 10
 11const cassandraclient = new cassandra.Client({
 12  contactPoints: config.cassandra.contactPoints,

Require statement not part of import statement

src/updatesafebrowsingdatabase.ts

  4import { logger, tracer, span } from './modules/logger'
  5const TimeUuid = require('cassandra-driver').types.TimeUuid;
  6const cassandra = require('cassandra-driver');
  7var axios = require('axios');  8
  9var forEach = require("for-each")
 10

Require statement not part of import statement

src/updatesafebrowsingdatabase.ts

  3import * as _ from 'lodash'
  4import { logger, tracer, span } from './modules/logger'
  5const TimeUuid = require('cassandra-driver').types.TimeUuid;
  6const cassandra = require('cassandra-driver');  7var axios = require('axios');
  8
  9var forEach = require("for-each")

Require statement not part of import statement

src/updatesafebrowsingdatabase.ts

  2//import _ = require('lodash');
  3import * as _ from 'lodash'
  4import { logger, tracer, span } from './modules/logger'
  5const TimeUuid = require('cassandra-driver').types.TimeUuid;  6const cassandra = require('cassandra-driver');
  7var axios = require('axios');
  8

Require statement not part of import statement

src/updatesafebrowsingdatabase.ts

  1const { config } = require('./../config.json');  2//import _ = require('lodash');
  3import * as _ from 'lodash'
  4import { logger, tracer, span } from './modules/logger'

Require statement not part of import statement

src/testyoutubekeys.ts

 3var authconfigfile = editJsonFile(`${__dirname}/../config.json`); 
 4var loadedAuthData = authconfigfile.get() 
 5 
 6const requestjson = require('request-json');  7 
 8var videoname = 'WMweEpGlu_U' 
 9

Require statement not part of import statement

src/testyoutubekeys.ts

 1const editJsonFile = require("edit-json-file");  2 
 3var authconfigfile = editJsonFile(`${__dirname}/../config.json`); 
 4var loadedAuthData = authconfigfile.get()

Require statement not part of import statement

src/testregister.ts

 2var testserver = '861845585282596874'
 3
 4import { DiscordInteractions } from "slash-commands";
 5const { config } = require('./../config.json'); 6
 7
 8const interaction = new DiscordInteractions({

Require statement not part of import statement

src/testCassandraTimeBasedIndex.ts

 5const id1 = TimeUuid.now();
 6const id2 = TimeUuid.fromDate(new Date());
 7
 8const { config } = require('./../config.json'); 9const cassandraclient = new cassandra.Client({
10    contactPoints: config.cassandra.contactPoints,
11    localDataCenter: config.cassandra.localDataCenter,

Require statement not part of import statement

src/testCassandraTimeBasedIndex.ts

 1
 2const cassandra = require('cassandra-driver');
 3
 4const TimeUuid = require('cassandra-driver').types.TimeUuid; 5const id1 = TimeUuid.now();
 6const id2 = TimeUuid.fromDate(new Date());
 7

Require statement not part of import statement

src/testCassandraTimeBasedIndex.ts

 1
 2const cassandra = require('cassandra-driver'); 3
 4const TimeUuid = require('cassandra-driver').types.TimeUuid;
 5const id1 = TimeUuid.now();

Require statement not part of import statement

src/server.ts

 18app.use(express.json());
 19
 20const https = require('https');
 21const http = require('http'); 22const webhook = new Topgg.Webhook(config.topgg.auth)
 23console.log('topgg auth', config.topgg.auth)
 24console.log(webhook)

Require statement not part of import statement

src/server.ts

 17// `app.use(express.json())` **before** your route handlers!
 18app.use(express.json());
 19
 20const https = require('https'); 21const http = require('http');
 22const webhook = new Topgg.Webhook(config.topgg.auth)
 23console.log('topgg auth', config.topgg.auth)

Require statement not part of import statement

src/server.ts

 11import { assignWith } from 'lodash';
 12import {logger,tracer,span} from './modules/logger'
 13
 14const cors = require('cors'); 15
 16// Parse JSON bodies for this app. Make sure you put
 17// `app.use(express.json())` **before** your route handlers!

Require statement not part of import statement

src/server.ts

  6
  7const TimeUuid = require('cassandra-driver').types.TimeUuid;
  8
  9const Topgg = require("@top-gg/sdk") 10
 11import { assignWith } from 'lodash';
 12import {logger,tracer,span} from './modules/logger'

Require statement not part of import statement

src/server.ts

  4const { config } = require('./../config.json');
  5const cassandra = require('cassandra-driver');
  6
  7const TimeUuid = require('cassandra-driver').types.TimeUuid;  8
  9const Topgg = require("@top-gg/sdk")
 10

Require statement not part of import statement

src/server.ts

  2var fs = require('fs')
  3const app = express();
  4const { config } = require('./../config.json');
  5const cassandra = require('cassandra-driver');  6
  7const TimeUuid = require('cassandra-driver').types.TimeUuid;
  8

Require statement not part of import statement

src/server.ts

  1const express = require('express');
  2var fs = require('fs')
  3const app = express();
  4const { config } = require('./../config.json');  5const cassandra = require('cassandra-driver');
  6
  7const TimeUuid = require('cassandra-driver').types.TimeUuid;

Require statement not part of import statement

src/server.ts

  1const express = require('express');
  2var fs = require('fs')  3const app = express();
  4const { config } = require('./../config.json');
  5const cassandra = require('cassandra-driver');

Require statement not part of import statement

src/server.ts

  1const express = require('express');  2var fs = require('fs')
  3const app = express();
  4const { config } = require('./../config.json');

Description

In other words, the use of forms such as var foo = require("foo") are banned. Instead use ES6 style imports or import foo = require("foo") imports.

Bad Practice

var foo = require('foo');
const foo = require('foo');
let foo = require('foo');

kylerchin / adorabot

Bad Practice

Recommended