http.NewRequest request send to http:// URLs GO-S1028Does not encrypt traffic with TLS, use HTTPS instead: http://some.example.tld/path
54 return
55 }
56
57 req, _ := http.NewRequest("GET", "http://some.example.tld/path", http.NoBody)58 w := httptest.NewRecorder()
59 handler.ServeHTTP(w, req)
60Does not encrypt traffic with TLS, use HTTPS instead: http://some.example.tld/path
44 },
45 })
46
47 req, _ := http.NewRequest("GET", "http://some.example.tld/path", http.NoBody)48 resp, err := h(context.Background(), req)
49 if err != nil {
50 t.Errorf("unexpected error: %s", err.Error())Does not encrypt traffic with TLS, use HTTPS instead: http://127.0.0.1:8080/_mux_endpoint?b=1
349 router := http.NewServeMux()
350 router.Handle("/_mux_endpoint", EndpointHandler(endpoint, p))
351
352 req, _ := http.NewRequest("GET", "http://127.0.0.1:8080/_mux_endpoint?b=1", io.NopCloser(&bytes.Buffer{}))353 req.Header.Set("Content-Type", "application/json")
354
355 w := httptest.NewRecorder()Does not encrypt traffic with TLS, use HTTPS instead: http://127.0.0.1:8080/_mux_endpoint?b=1
305 router := http.NewServeMux()
306 router.Handle("/_mux_endpoint", EndpointHandler(endpoint, p))
307
308 req, _ := http.NewRequest("GET", "http://127.0.0.1:8080/_mux_endpoint?b=1", io.NopCloser(&bytes.Buffer{}))309 req.Header.Set("Content-Type", "application/json")
310
311 w := httptest.NewRecorder()Does not encrypt traffic with TLS, use HTTPS instead: http://127.0.0.1:8080/_mux_endpoint?b=1
254 router := http.NewServeMux()
255 router.Handle("/_mux_endpoint", EndpointHandler(endpoint, p))
256
257 req, _ := http.NewRequest("GET", "http://127.0.0.1:8080/_mux_endpoint?b=1", io.NopCloser(&bytes.Buffer{}))258 req.Header.Set("Content-Type", "application/json")
259
260 w := httptest.NewRecorder()
Description
Requests sent via http.NewRequest to http:// URLs is dangerous because the
server is attempting to connect to a website that does not encrypt traffic with
TLS. Instead, it is recommended to use https://.
Bad practice
req, err := http.NewRequest("GET", "http://deepsource.io", nil)
Recommended
req, err := http.NewRequest("GET", "https://deepsource.io", nil)