else
/ elif
used after return
PYL-R1705123 include_extras = False
124 watchlist_resp = requests.get(
125 "https://api.seesaw.abc.net.au/v1/saved/watchlist/show?source=iview&slug=watchlist&raw=1&done=0&UID="+uid)
126 if watchlist_resp.status_code == 200:127 watchlist = json.loads(watchlist_resp.content.decode())
128 fg = FeedGenerator()
129 fg.id('https://iview-rss.maxstuff.net/watchlist/'+uid)
60 fg.language('en')
61 fg.author({'name': 'Max', 'uri': 'https://maxstuff.net'})
62 fg.description(show_info['description'])
63 if show_info['type'] == 'series': 64 for series in show_info['_embedded']['seriesList']:
65 current_series = json.loads(
66 requests.get(
The use of else
or elif
becomes redundant and can be dropped if the last statement under the leading if
/ elif
block is a return
statement.
In the case of an elif
after return
, it can be written as a separate if
block.
For else
blocks after return
, the statements can be shifted out of else
. Please refer to the examples below for reference.
Refactoring the code this way can improve code-readability and make it easier to maintain.
def classify_number(x):
if x % 2 == 0:
return 'Even'
else:
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
elif x % 2 == 0 and x < 0:
return 'Even and Negative'
elif x % 2 != 0 and x < 0:
return 'Odd and Negative.'
else:
return 'Odd'
def classify_number(x):
if x % 2 == 0:
return 'Even'
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
if x % 2 == 0 and x < 0:
return 'Even and Negative'
if x % 2 != 0 and x < 0:
return 'Odd and Negative'
return 'Odd'