Unnecessary
else / elif used after return PYL-R1705
Style
Major
2 years ago
—
3 years old
Unnecessary "elif" after "return"
34 "`Bot doesn't seem to be responding.`")
35 response_link = response.text
36 await bot.send_read_acknowledge(linkbot)
37 if response_link.startswith("You need to join"):38 return await eris.edit(f"Please check {linkbot}")
39 elif response_link.startswith("**Title:"):
40 for link, _ in response.get_entities_text(keeper):
Description
The use of else or elif becomes redundant and can be dropped if the last statement under the leading if / elif block is a return statement.
In the case of an elif after return, it can be written as a separate if block.
For else blocks after return, the statements can be shifted out of else. Please refer to the examples below for reference.
Refactoring the code this way can improve code-readability and make it easier to maintain.
Bad practice
def classify_number(x):
if x % 2 == 0:
return 'Even'
else:
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
elif x % 2 == 0 and x < 0:
return 'Even and Negative'
elif x % 2 != 0 and x < 0:
return 'Odd and Negative.'
else:
return 'Odd'
Preferred:
def classify_number(x):
if x % 2 == 0:
return 'Even'
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
if x % 2 == 0 and x < 0:
return 'Even and Negative'
if x % 2 != 0 and x < 0:
return 'Odd and Negative'
return 'Odd'