Attribute defined outside
__init__ PYL-W0201
Anti-pattern
Minor
3 years ago
—
3 years old
Attribute 'output_progress_max' defined outside __init__
55 out.flush()
56
57 def output_progress_start(self):
58 self.output_progress_max = 0 59
60 def output_progress(self, message, err=False, nl=True):
61 l = max(self._output_progress_max, len(message))
Description
Defining an instance attribute outside __init__ affects the readability of code. It is expected to find all the attributes an instance may have by reading its __init__ method. If there is a need to initialize attribute via sub-initialization methods, it is recommended to assign attributes to None in the init then call the sub-initialization methods.