Function contains unused argument PYL-W0613
Anti-pattern
Major
3 years ago
—
3 years old
Unused argument 'chat_id'
48 return True
49
50
51async def get_all_chats(chat_id):52 return cli.find({'chat_id': chatid})
Unused argument 'nl'
57 def output_progress_start(self):
58 self.output_progress_max = 0
59
60 def output_progress(self, message, err=False, nl=True): 61 l = max(self._output_progress_max, len(message))
62 self._output_progress_max = l
63 message_pad = message.ljust(l)Unused argument 'added'
429 os.rename(file_name_temp_path, file_name_path)
430 self.log('Done')
431
432 def download_progress(self, status, start, now, offset, added, current, total):433 if status is self.DL_PROGRESS_READ:
434 return
435
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42