PYL-W0714 · Exceptions are overlapping

muhammedfurkan / TelethonUserBot

Active

Exceptions are overlapping PYL-W0714

Anti-pattern

Major

2 years ago — 2 years old

Overlapping exceptions (BadRequestError is an ancestor class of UserAdminInvalidError)

534                        EditBannedRequest(mutedMessage.chat_id,
535                                          mutedMessage.sender_id, rights)
536                    )
537                except (UserAdminInvalidError, ChatAdminRequiredError, BadRequestError, UserIdInvalidError):538                    pass
539    for i in gmuted:
540        if i['chat_id'] == mutedMessage.sender_id:

Overlapping exceptions (BadRequestError is an ancestor class of ChatAdminRequiredError)

userbot/modules/admin.py

534                        EditBannedRequest(mutedMessage.chat_id,
535                                          mutedMessage.sender_id, rights)
536                    )
537                except (UserAdminInvalidError, ChatAdminRequiredError, BadRequestError, UserIdInvalidError):538                    pass
539    for i in gmuted:
540        if i['chat_id'] == mutedMessage.sender_id:

Overlapping exceptions (BadRequestError is an ancestor class of UserIdInvalidError)

userbot/modules/admin.py

534                        EditBannedRequest(mutedMessage.chat_id,
535                                          mutedMessage.sender_id, rights)
536                    )
537                except (UserAdminInvalidError, ChatAdminRequiredError, BadRequestError, UserIdInvalidError):538                    pass
539    for i in gmuted:
540        if i['chat_id'] == mutedMessage.sender_id:

Description

Two or more exceptions in the same exception handler clause that are identical or parts of the same inheritance hierarchy (i.e. overlapping). It is recommmend to refactor this.

Not preferred:

class SomeException(Exception):
    pass

class SubclassException(SomeException):
    pass

try:
    raise SubclassException()
except (SomeException, SubclassException):
    pass

Here, SubclassException has been derived from SomeException, which makes it overlapping.

Preferred:

class SomeException(Exception):
    pass

class SubclassException(SomeException):
    pass

try:
    raise SubclassException()
except SomeException:
    pass