Detected the use of
alert, confirm and prompt JS-0052
Anti-pattern
Minor
2 years ago
—
2 years old
Unexpected alert.
205 updateRecords();
206 }).catch((error) => {
207 console.error("Error removing document: ", error);
208 alert(error);209 });
210}
211Unexpected alert.
132 console.log(record);
133
134 if((record.dateAndTime === "")|| (record.title === "") || (record.amount === "") ||((record.assetType === "expense")&&(record.exp_type === ""))||((record.assetType === "asset")&&(record.ass_type === ""))||((record.assetType === "liab")&&(record.liab_type === "")) ){
135 alert("All fields must filled!");136 return;
137 }
138 console.log("successfully filled");
Description
JavaScript's alert, confirm and prompt functions are widely considered to be obtrusive as UI elements and should be replaced by a more appropriate custom UI implementation.
Furthermore, alert is often used while debugging code, which should be removed before deployment to production.
Bad Practice
alert("here!");
confirm("Are you sure?");
prompt("What is your name?", "John Doe");
Recommended
customAlert("Something happened!");
customConfirm("Are you sure?");
customPrompt("Who are you?");
function foo() {
const alert = myCustomLib.customAlert;
alert();
}